Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1182: Added cache invalidation to liip:imagine:cache:remove command #3130

Merged
merged 3 commits into from
Jan 3, 2022
Merged

IBX-1182: Added cache invalidation to liip:imagine:cache:remove command #3130

merged 3 commits into from
Jan 3, 2022

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Dec 15, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-1182
Type bug
Target eZ Platform version v2.5
BC breaks no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 self-assigned this Dec 15, 2021
@barw4 barw4 requested a review from a team December 15, 2021 21:44
konradoboza
konradoboza approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@konradoboza konradoboza requested a review from a team December 16, 2021 07:51
Steveb-p
Steveb-p approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of relying on decorating services, but 👍

@alongosz alongosz changed the title IBX-1182: Cache invalidation when using liip:imagine:cache:remove command IBX-1182: Added cache invalidation to liip:imagine:cache:remove command Dec 23, 2021
@barw4 barw4 requested a review from alongosz December 23, 2021 11:17
@barw4 barw4 requested a review from alongosz December 23, 2021 11:33
@micszo micszo self-assigned this Dec 23, 2021
@micszo
Copy link
Member

micszo commented Dec 23, 2021

Can someone confirm the failure is random? https://app.travis-ci.com/github/ezsystems/ezpublish-kernel/jobs/553388217

@barw4
Copy link
Member Author

barw4 commented Dec 23, 2021 •
edited
Loading

Can someone confirm the failure is random? https://app.travis-ci.com/github/ezsystems/ezpublish-kernel/jobs/553388217

Looks random, should we re-run?

//Edit green after job restart

micszo
micszo approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.26 with diff.

@micszo micszo removed their assignment Jan 3, 2022
@alongosz alongosz merged commit f81a452 into 7.5 Jan 3, 2022
@alongosz alongosz deleted the ibx-1182-cache-invalidating-liip-imagine branch January 3, 2022 15:41
@barw4
Copy link
Member Author

barw4 commented Jan 3, 2022 •
edited
Loading

Merged into:
ezplatform-kernel/1.3: ezsystems/ezplatform-kernel@0e73e9f
ibexa/core/main: ibexa/core#43

@barw4 barw4 mentioned this pull request Jan 4, 2022
Merged
alongosz added a commit to ibexa/core that referenced this pull request Jan 4, 2022
@alongosz
Merged branch '1.3' of ezsystems/ezplatform-kernel into main (#43)
df2c0db 
Merge up of ezsystems/ezpublish-kernel#3130 into ibexa/core:4.0.x-dev

For more details see https://issues.ibexa.co/browse/IBX-1182 or #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@barw4 barw4

Labels
Bug QA approved Ready for MERGE
Milestone
No milestone
6 participants
@barw4 @micszo @mikadamczyk @Steveb-p @alongosz @konradoboza