Fix EZP-20669: Wrong Format of eZPage field in REST API #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Segmentation fault again in Travis tests... |
|
+1 on the concept here both for 5.1 and 5.2 when Travis and @lolautruche / @patrickallaert agrees :) |
|
There for segmentation fault 70d55bc. 😷 |
|
+1 |
pspanja
added a commit
that referenced
this pull request
May 6, 2013
Fix EZP-20669: Wrong Format of eZPage field in REST API
|
Changes Unknown when pulling 70d55bc on fix-EZP-20669-rest-ezpage-format into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue https://jira.ez.no/browse/EZP-20669
PHP's serialized format was used for hash before, this adds dedicated HashConverter class to convert to and from Page Value object.
Not in linked issue:
added
@coversannotations and fixed some wrong@returnannotations in FieldType processor tests