EZP-21129: Get rid of RMF\Request #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| private $router; | ||
|
|
||
| private $restRoutesPrefix; |
|
Okay, tests pass. The review is really open now :-) |
| $url = $this->restRoutesPrefix . $url; | ||
| } | ||
|
|
||
| // we create a request with a new context |
There was a problem hiding this comment.
Inline doc is nice, but this only says what it does, not why ;)
|
+0.8, don't knwo that much about the REST impl. review ping @pspanja @lolautruche |
| * @param array $match Match array returned by Router::match() / Router::matchRequest() | ||
| * @return bool | ||
| */ | ||
| private function matchesRestRequest( $match ) |
|
Beside my remarks, looks good +1. However, ensure that tests pass on Travis 😃 |
added 18 commits
July 5, 2013 12:00
This reverts commit 057b6271705deb6d2d31defd0412460a6138dde8.
The controllers currently have a distinct httpFoundationRequest property so that unreplaced calls still work. Calls to ->variables and some ->request, including path, have been replaced already.
Added a new RequestParser, implemented in EzPublishRestBundle\RequestParser\Router, that has a parseHref method, and replaced in all Input\Parser implementations & tests.
The REST prefix is for now explicitely allowed in payloads, since it was allowed since 5.0. Must be fixed in another story (EZP-21176)
added 7 commits
July 5, 2013 12:00
|
We should be good now, but I'm still short +0.2... |
|
|
||
| if ( !isset( $parsingResult[$attribute] ) ) | ||
| { | ||
| throw new InvalidArgumentException( "No such attribute '$attribute' in route matched from $href\n" . print_r( $parsingResult, true ) ); |
There was a problem hiding this comment.
Nitpick as this it seems to be pending for removal, but Exceptions\InvalidArgumentException should be used.
|
Looks good from my side, +1. |
|
Merged: fad2be9...3489b7b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Totally removes the requirement on
RMF\Request. The Symfony Request is used instead, directly in Controllers.The REST Client tests still work because they still use the old
requestParser\eZPublishwith hardcoded routes, but hasn't been refactored here.TODO
RMF\Request