New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EZP-21054: Anchor tag is not transformed by xsl #454
Conversation
Nice, +1. |
This Pull Request does not respect our Coding Standards, please, see the report below:
|
Thanks, +1 ! |
(CS fixed, hopefully...) |
*/ | ||
class Html5Test extends PHPUnit_Framework_TestCase | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CS: empty line
+1, but maybe squash the commits :) |
+1 |
https://travis-ci.org/ezsystems/ezpublish-kernel/jobs/9262577#L266 |
@dpobel maybe a simple stylesheet would be a good solution there, something in the like of http://git.io/yG-LXQ. Otherwise +1. |
I tried to fix the unit test in PHP 5.3.3, I'm waiting for a green light from Travis to merge this one. |
JIRA issue: https://jira.ez.no/browse/EZP-21054
Description
the
anchor
tag is not handled by our XSLT stylesheets. As a result, when a XmlText field contains ananchor
element, it is rendered without any transformation, and of course this is not valid in HTML5.While at it, I also added unit tests for the Html5 converter.
Tests
manual tests + unit tests