Fix EZP-21924: [SensioLabsInsight] Refactor LegacyKernelController to be less than 20 lines #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $view The view name | ||
| * @param array $parameters An array of parameters to pass to the view | ||
| * | ||
| * @return LegacyResponse A LegacyResponse instance |
There was a problem hiding this comment.
\eZ\Bundle\EzPublishLegacyBundle\LegacyResponse
|
To make the |
… be less than 20 lines
|
@dpobel Done. And |
|
still +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/EZP-21924
See https://insight.sensiolabs.com/projects/0885c0ce-4b9f-4b89-aa9c-e8f9f7a315e0/analyses/7#rule-24-034
This PR refactors
LegacyKernelControllerto be thiner and delegatesLegacyResponsegeneration to newLegacyResponseManagerservice.Note that
mapHeaders()cannot be tested because of issues in PHPUnit with process isolation (see also this issue on testing headers with PHPUnit)