EZP-22098 Fix_min_max_value_for_contenttype #773
Conversation
| @@ -2,7 +2,7 @@ | |||
| /** | |||
| * File containing the Float converter | |||
| * | |||
| * @copyright Copyright (C) 1999-2014 eZ Systems AS. All rights reserved. | |||
| * @copyright Copyright (C) 1999-2013 eZ Systems AS. All rights reserved. | |||
|
Now it is ready for a review and comments :) @andrerom @lolautruche @bdunogier |
| ); | ||
| $floatValidatorParameters = array( 'minFloatValue' => false, 'maxFloatValue' => false ); | ||
|
|
||
| if ( $storageDef->dataFloat4 & self::HAS_MIN_VALUE === self::HAS_MIN_VALUE ) |
There was a problem hiding this comment.
Does the === part work?
In legacy we usually have things like this:
if ( $clearCacheType & self::CLEAR_NODE_CACHE )
There was a problem hiding this comment.
The fact that we did it one way in legacy is barely proof of anything ;-)
php > $flag = 2; $min = 1; $max = 2;
php > var_dump( $flag&$min );
int(0)
php > var_dump( $flag&$max );
int(2)But the === could be removed, since we will either get 0 or the tested value.
There was a problem hiding this comment.
ok, but if this is more readable I'm all for it, but I did not find it more readable :)
|
+1 |
|
This Pull Request does not respect our PHP Coding Standards, please, see the report below: |
|
ready for review :) |
| @@ -119,8 +119,12 @@ public function validate( FieldDefinition $fieldDefinition, SPIValue $fieldValue | |||
|
|
|||
| $validationErrors = array(); | |||
|
|
|||
| // 0 and False are unlimited value for maxIntegerValue | |||
There was a problem hiding this comment.
CS : indent this line :)
|
Added little nitpicks, but no blocker for a +1 once they're fixed. |
| } | ||
|
|
||
| $fieldDef->fieldTypeConstraints->validators = array( self::FLOAT_VALIDATOR_IDENTIFIER => $intValidatorParameters ); |
There was a problem hiding this comment.
Make sure you harmonize the way to assign validators, it's done a bit differently in both types.
|
+1 |
1 similar comment
|
+1 |
…_of_contenttype EZP-22098 Fix_min_max_value_for_contenttype
JIRA link: https://jira.ez.no/browse/EZP-22098
Description
The goal here is to set 0 as the maximum or the minimum allowed value on a Float or Integer field definition.