Fix EZP-22991: Added file exists control for parse method

[dymissy]

After update to 2014.03 version, when functional tests are launched the path of tr files is wrong. This PR add a file exists check before to launch the parseString method.

This is not the better solution but I'm not sure if I can thrown an Exception (if so which one?) and, above all, if I can fix the path directly in the parse method. I don't know if this method is used elsewhere and if in other cases the path works fine.

Any suggestions in order to fix the issue are more than welcome.

[ezrobot]

This Pull Request does not respect our PHP Coding Standards, please, see the report below:

FILE: ...ish/Core/Persistence/TransformationProcessor/DefinitionBased/Parser.php
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 90 | ERROR | Expected "if (...)\n...{\n"; found "if(...)\n...{\n"
 90 | ERROR | A space is required after opening parenthesis of function call
 90 | ERROR | A space is required before closing parenthesis of function call
 94 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------

[andrerom]

I would opt for NotFoundException for this case, but ping @pspanja for second opinion.

[dymissy]

Thanks @andrerom!

👍 for the Exception but I'm not sure if NotFoundException is the better choice. This is an example of the output returned with this class:

Could not find 'file' with identifier 'eZ/Publish/Core/Persistence/Tests/TransformationProcessor/_fixtures/transformations/ascii.tr'

I think it is developed for contents more than for files but I'd like to know your point of view.

[pspanja]

@andrerom @dymissy I would rather throw RuntimeException, as this is something that should IMO crash the app. But we should also fix the problem, and I'm not sure how to reproduce this?