Made Legacy IO handler server URI aware #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will now call eZClusterFileHandler::applyServerUri() to get the right URI.
|
+1, but you should fix tests. |
|
+0,5 ( more legacy fallback :( ) |
|
Since it is Legacy IO handler, I'm +1 with tests fixed. |
|
@andrerom Let's write a native DFS driver then 😉 |
|
@bdunogier Still valid? |
Nope, not as is, the file's gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the new stack compatible with the addition of the
applyServerUri()method recently applied to the cluster interfaces, making it possible to use absolute URIs on a different host for images.Tested manually...