Fix EZP-23176: Sessions are always started for anonymous user #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -988,7 +988,9 @@ static function setCurrentlyLoggedInUser( $user, $userID, $flags = 0 ) | |||
| if ( !( $flags & self::NO_SESSION_REGENERATE) ) | |||
| eZSession::regenerate(); | |||
|
|
|||
| eZSession::set( 'eZUserLoggedInID', $userID ); | |||
| if ( $userID != self::anonymousId() || eZSession::hasStarted() ) | |||
| eZSession::set( 'eZUserLoggedInID', $userID ); | |||
There was a problem hiding this comment.
cs here? (more white spaces needed)
edit: don't know if we should worry about cs things for legacy code though. feel free to discard this comment if so.
|
Scary, but might be good! |
|
Updated, cleanup() will try to remove session variables which actually starts a session... |
|
hmm, I think I might prefer the other one, this one looks a bit risky.. |
|
Alternative: ezsystems/ezpublish-kernel#936 |
|
Closing |
lolautruche
added a commit
to ezsystems/ezpublish-kernel
that referenced
this pull request
Jul 23, 2014
> https://jira.ez.no/browse/EZP-23176 Alternative of #932 and ezsystems/ezpublish-legacy#1033 by @joaoinacio . In security mapper, user was injected in legacy even if the current user wasn't authenticated. Problem is that `eZUser::setLoggedInUser()` always sets a session variable… This patch ensures user is authenticated in security context before injecting the user. Tests have been updated and improved.
bdunogier
pushed a commit
to ezsystems/LegacyBridge
that referenced
this pull request
Jan 21, 2015
> https://jira.ez.no/browse/EZP-23176 Alternative of #932 and ezsystems/ezpublish-legacy#1033 by @joaoinacio . In security mapper, user was injected in legacy even if the current user wasn't authenticated. Problem is that `eZUser::setLoggedInUser()` always sets a session variable… This patch ensures user is authenticated in security context before injecting the user. Tests have been updated and improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-23176
eZUser::setCurrentlyLoggedInUser()always starts a session, even for anonymous.Replaces ezsystems/ezpublish-kernel#932
Essentially this will not start a new session if the (new) current user is anonymous.
If a previously user was set, and setCurrentlyLoggedInUser() is for anonymous, a session should already exist, so it will still update the user ID.