Fix EZP-23176: Lazy sessions are not honored in 5.3 #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2014
| @@ -81,13 +89,26 @@ public function onKernelBuilt( PostBuildKernelEvent $event ) | |||
| function () use ( $currentUser ) | |||
| { | |||
| $legacyUser = eZUser::fetch( $currentUser->id ); | |||
| eZUser::setCurrentlyLoggedInUser( $legacyUser, $legacyUser->attribute( 'contentobject_id' ), eZUser::NO_SESSION_REGENERATE ); | |||
| // "1" stands for eZUser::NO_SESSION_REGENERATE. | |||
| // Using raw value to be keep being testable. | |||
There was a problem hiding this comment.
Basically, when you want to mock static methods, you need to use class alias/overload with Mockery. Problem is that it doesn't keep class constants, so here test would crash with a fatal.
|
Besides the comment, and travis, +1 |
> https://jira.ez.no/browse/EZP-23176 Alternative of #932 and ezsystems/ezpublish-legacy#1033 by @joaoinacio . In security mapper, user was injected in legacy even if the current user wasn't authenticated. Problem is that `eZUser::setLoggedInUser()` always sets a session variable… This patch ensures user is authenticated in security context before injecting the user. Tests have been updated and improved.
|
+1 |
lolautruche
added a commit
that referenced
this pull request
Jul 25, 2014
…onymous Fix EZP-23176: Lazy sessions are not honored in 5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative of #932 and ezsystems/ezpublish-legacy#1033 by @joaoinacio .
In security mapper, user was injected in legacy even if the current user wasn't authenticated. Problem is that
eZUser::setLoggedInUser()always sets a session variable, and thus starts a session.This patch ensures user is authenticated in security context before injecting the user.