Updated instances of count() that would cause a warning in 7.2 #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 12, 2019 15:27
vidarl
requested changes
Oct 24, 2019
vidarl
approved these changes
Oct 24, 2019
andrerom
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
+1, good follow up on #1382 here, but we need this on 2019.03 (or 2017.12 if someone asks for it) as this is bug fix.
Are you able to rebase on <ez-upstream-name>/2019.03? OR able to squash your commits (meld all your commit into one), and force push so we can cherry pick it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic updated after the following example to give a reasonable approximation of how count() worked on scalar objects previous to PHP 7.2
https://stackoverflow.com/questions/49662029/count-emitting-an-e-warning