Fixed #019565: eZOrder (statistics)

[vaxvhbe]

Fatal error in function orderStatistics

sql error when there is no product for selected date

Query error (1064): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') ORDER BY id ASC' at line 2.
Query: SELECT id, section_id, owner_id, contentclass_id, name, published, modified, current_version, status, remote_id, language_mask, initial_language_id FROM ezcontentobject WHERE id IN ( ) ORDER BY id ASC

[patrickallaert]

Previous comments made by @crevillo taken into account by @taenadil.
I'm +1 with those changes.

[crevillo]

So, you mean that the pull request is ready to be merged or do you prefer more testing on my side?
Thanks, Patrick.

[nfrp]

Hi guys,

I do not happen to see @crevillo 's previous comments in the log here, to which ones were you referring @patrickallaert ?
However, if you guys have tested the PR, feel free to raise the final "Please merge" flag.

Cheers !

[vaxvhbe]

Hi @nfrp

The last comments are viewable here https://github.com/taenadil/ezpublish/commit/7be0724cd0ba0555f8054088324aba7caecb8e2d#kernel/classes/ezorder.php-P20

[crevillo]

Hi @nfrp. I can't see them now either. It was CS consideration that as @patrickallaert said, had been perfectly fixed.
My doubt if @patrickallaert 's comment means that he tested also the correct behaviour and that the issue has been fixed, or they were only refering to the coding standard part and so there's a need of more testing on my side.

If the answer is a, then feel free to merge, if it's b, let me know! :)

[crevillo]

Hello. I've tested it again anyway. I can reproduce the issue and indeed this patch fix it.
So, @patrickallaert, @nfrp, @lolautruche, @andrerom, anyone for merging?

Thank you!

Carlos, eZ Diff Squad

[nfrp]

Wonderful guys, thanks for the contribution and the review !!

[nfrp]

Thanks @crevillo for representing the eZ Diff Squad, and thanks @taenadil for the contribution !