EZP-29979: As a developer I would like to use getLocation method on ContentCreateSuccessView and ContentEditSuccessView #270
Conversation
…ontentCreateSuccessView and ContentEditSuccessView
kmadejski
requested review from
andrerom,
Nattfarinn,
alongosz,
webhdx and
ViniTou
Co-Authored-By: kmadejski <kmadejski@live.com>
Co-Authored-By: kmadejski <kmadejski@live.com>
There was a problem hiding this comment.
Sadly, it breaks when trying to publish a previously saved draft.
I've used dev env with debug enabled.
Steps:
- Login as admin
- Go to Content
- Start creating a Folder (enter "TestName" as name)
- Save draft
- Publish
It fails with:
Type error: Argument 1 passed to EzSystems\RepositoryForms\Content\View\ContentEditSuccessView::setLocation() must be an instance of eZ\Publish\API\Repository\Values\Content\Location, null given, called in /home/vagrant/ee_demo/vendor/ezsystems/repository-forms/lib/Content/View/Builder/ContentEditViewBuilder.php on line 126
I believe we shouldn't set the location to null there - it should be the location that was created when publish action was executed? (If it's possible).
kmadejski
added
Ready for review
Ready for QA
and removed
Work in progress
Ready for review
labels
|
@mnocon do you see any chance to give it another round of testing? 🙂 |
|
@kmadejski there is a chance 😉 But you're probably aware that 60% of our QA team is on sick leave and it complicates things a bit |
There was a problem hiding this comment.
I know that the ticket mentions ContentCreateSuccessView and ContentEditSuccessView only (and it works correctly for them), but wouldn't it make sense to implement LocationValueView also for EzSystems\EzPlatformPageBuilder\View\PageView, EzSystems\EzPlatformFormBuilder\View\FieldConfigurationView and EzSystems\RepositoryForms\User\View\UserUpdateView?
This way we would provide unified experience for developers across all these editing views.
Also, ping @DominikaK - not sure if it's something that is doc-worthy.
|
Good question @mnocon, honestly, I don't know. @ViniTou / @webhdx / @Nattfarinn / @andrerom |
…ontentCreateSuccessView and ContentEditSuccessView (ezsystems#270) * EZP-29979: As a developer I would like to use getLocation method on ContentCreateSuccessView and ContentEditSuccessView * Removed null from setLocation * Update lib/Content/View/ContentCreateSuccessView.php Co-Authored-By: kmadejski <kmadejski@live.com> * Update lib/Content/View/ContentEditSuccessView.php Co-Authored-By: kmadejski <kmadejski@live.com> * Recovered possiblity to pass null to setLocation method
JIRA: https://jira.ez.no/browse/EZP-29979