Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29979: As a developer I would like to use getLocation method on ContentCreateSuccessView and ContentEditSuccessView #270

Merged
merged 5 commits into from Mar 4, 2019
Merged

EZP-29979: As a developer I would like to use getLocation method on ContentCreateSuccessView and ContentEditSuccessView #270

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b78b47
EZP-29979: As a developer I would like to use getLocation method on C…
kmadejski Jan 2, 2019
316d9fd
Removed null from setLocation
kmadejski Jan 3, 2019
c04d440
Update lib/Content/View/ContentCreateSuccessView.php
webhdx Jan 7, 2019
c904a87
Update lib/Content/View/ContentEditSuccessView.php
webhdx Jan 7, 2019
51ef931
Recovered possiblity to pass null to setLocation method
kmadejski Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Content/View/Builder/ContentCreateViewBuilder.php
View file
Open in desktop
Expand Up @@ -103,7 +103,10 @@ public function buildView(array $parameters)
);

if ($response = $this->contentActionDispatcher->getResponse()) {
return new ContentCreateSuccessView($response);
$view = new ContentCreateSuccessView($response);
$view->setLocation($location);

return $view;
}
}

Expand Down
5 changes: 4 additions & 1 deletion lib/Content/View/Builder/ContentEditViewBuilder.php
View file
Open in desktop
Expand Up @@ -122,7 +122,10 @@ public function buildView(array $parameters)
);

if ($response = $this->contentActionDispatcher->getResponse()) {
return new ContentEditSuccessView($response);
$view = new ContentEditSuccessView($response);
$view->setLocation($location);

return $view;
}
}

Expand Down
23 changes: 22 additions & 1 deletion lib/Content/View/ContentCreateSuccessView.php
View file
Open in desktop
Expand Up @@ -7,12 +7,17 @@

namespace EzSystems\RepositoryForms\Content\View;

use eZ\Publish\API\Repository\Values\Content\Location;
use eZ\Publish\Core\MVC\Symfony\View\BaseView;
use eZ\Publish\Core\MVC\Symfony\View\LocationValueView;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Controller\ControllerReference;

class ContentCreateSuccessView extends BaseView
class ContentCreateSuccessView extends BaseView implements LocationValueView
{
/** @var \eZ\Publish\API\Repository\Values\Content\Location|null */
private $location;

/**
* @param \Symfony\Component\HttpFoundation\Response $response
*
Expand All @@ -25,4 +30,20 @@ public function __construct(Response $response)
$this->setResponse($response);
$this->setControllerReference(new ControllerReference('ez_content_edit:createWithoutDraftSuccessAction'));
}

/**
* @param \eZ\Publish\API\Repository\Values\Content\Location $location
*/
public function setLocation(Location $location)
kmadejski marked this conversation as resolved.
Show resolved Hide resolved
{
$this->location = $location;
}

/**
* @return \eZ\Publish\API\Repository\Values\Content\Location|null
*/
public function getLocation(): ?Location
{
return $this->location;
}
}
23 changes: 22 additions & 1 deletion lib/Content/View/ContentEditSuccessView.php
View file
Open in desktop
Expand Up @@ -7,12 +7,17 @@

namespace EzSystems\RepositoryForms\Content\View;

use eZ\Publish\API\Repository\Values\Content\Location;
use eZ\Publish\Core\MVC\Symfony\View\BaseView;
use eZ\Publish\Core\MVC\Symfony\View\LocationValueView;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Controller\ControllerReference;

class ContentEditSuccessView extends BaseView
class ContentEditSuccessView extends BaseView implements LocationValueView
{
/** @var \eZ\Publish\API\Repository\Values\Content\Location|null */
private $location;

/**
* @param \Symfony\Component\HttpFoundation\Response $response
*
Expand All @@ -25,4 +30,20 @@ public function __construct(Response $response)
$this->setResponse($response);
$this->setControllerReference(new ControllerReference('ez_content_edit:editVersionDraftSuccessAction'));
}

/**
* @param \eZ\Publish\API\Repository\Values\Content\Location $location
*/
public function setLocation(Location $location)
kmadejski marked this conversation as resolved.
Show resolved Hide resolved
{
$this->location = $location;
}

/**
* @return \eZ\Publish\API\Repository\Values\Content\Location|null
*/
public function getLocation(): ?Location
{
return $this->location;
}
}