Fieldtype values editing support #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
force-pushed
the
feature-fieldtypes_support-ezp24339
branch
from
53e7bac
to
a710831
Compare
| public function theEditFormShouldContainAFieldsetNamedAfterTheFieldDefinition() | ||
| { | ||
| $this->assertElementContainsText( | ||
| sprintf('div.ezfield-identifier-%s fieldset legend', self::$fieldIdentifier), |
There was a problem hiding this comment.
The selector can be used without the div
|
+1 |
2 tasks
|
No real need to +1 the whole PR yet, as the topic branches aren't merged yet. But I'll take that as a +1 on the BDD :-) |
* EZP-25775: Checkbox content edition support
A FormTypeBasedFieldValueFormMapper is added. It comes with an abstract ezrepoforms.field_type.form_mapper.form_type_based service. It can be used to map fieldtype values when no particular configuration is required, and a single fieldtype is used (primitive or custom).
The service tag ez.fieldType.formMapper is deprecated, and splitted into ez.fieldFormMapper.value and ez.fieldFormMapper.definition. The dispatcher pass & dispatcher are updated to distinguish both while still being backward compatible.
…dit_support User FieldType content edit support (EZP-27530)
* Fix EZP-25776: Selection content edition support * Fix content type of behat context not being reloaded after updating the field definition.
|
All todos taken care of, and tests are passing. I suggest we merge this, what do you think @glye ? |
|
I say not nay, I say aye! 🎩 |
|
And here we merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
BDD coverage for User (will fail until implementation is merged from #83) and TextLine fieldtypes(moved to #83)Other pull-requests