allow callto, skype, xmpp schemes #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bartbutler, sorry it took a long time to look at this patch. I'm a bit nervous about allowing unrestricted callto/skype/xmpp URLs. In the past, these protocols have been used to mount local exploits from applications which did not properly validate inputs (yes, this is not really an HTML Purifier problem, but I'd prefer for HTML Purifier to not accept HTML that could potentially pwn your computer.) I'm not going to accept this patch. I will accept a patch that looks in the contents and validates them so they look reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minimal validation, given that these schemes have a ton of flexibility.