New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Introduce shared matrix parameter-Jacobian products #203

Merged

f-dangel merged 33 commits into f-dangel:development from schaefertim:generalize-jac-t-interface

Jul 29, 2021

Contributor

schaefertim commented Jul 13, 2021 •

edited

Loading

Works on https://github.com/fKunstner/backpack-discuss/issues/105

find seeds such that all tests run on all python and torch versions
include RNN and LSTM into test_param_jac_t_mat_prod -> test coverage backpack/core/derivatives/lstm.py
include save_memory into test_param_jac_t_mat_prod -> test coverage backpack/core/derivatives/convnd.py

f-dangel and others added 13 commits

June 9, 2021 16:03


          [core] Design prototype for transpose JVPs, enable for bias

3d162e1


          param_mjp: shape check: accept vectors

8adcf18


          Merge branch 'development' into generalize-jac-t-interface

58e2122

# Conflicts:
#	backpack/core/derivatives/basederivatives.py


          include subsampling

f612058


          param_mjp: shape check: accept vectors

52d5453


          delete {param}_jac_t_mat_prod methods

0c1986d


          delete private methods

10515d4


          introduce single test test_param_jac_t_mat_prod

b0d3764


          seed

03763a0


          seed

bf3bc0a


          include RNN and LSTM in test_param_jac_t_mat_prod

370622c


          include save_memory in test_param_jac_t_mat_prod

309dfa9


          include save_memory in test_param_jac_t_mat_prod

14e5e55

schaefertim marked this pull request as ready for review

July 15, 2021 09:05

f-dangel reviewed

View reviewed changes

test/core/derivatives/implementation/backpack.py Outdated Show resolved Hide resolved

schaefertim and others added 2 commits

July 19, 2021 11:07


          refactor test derivatives implementation

f649512


          Merge branch 'development' into generalize-jac-t-interface

ac5a1b3

f-dangel reviewed

View reviewed changes

backpack/core/derivatives/basederivatives.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

backpack/core/derivatives/basederivatives.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

backpack/core/derivatives/basederivatives.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

backpack/core/derivatives/shape_check.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

backpack/core/derivatives/shape_check.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

backpack/core/derivatives/shape_check.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

test/core/derivatives/implementation/base.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

test/core/derivatives/implementation/backpack.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

test/core/derivatives/implementation/autograd.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

test/core/derivatives/derivatives_test.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

test/core/derivatives/derivatives_test.py Outdated Show resolved Hide resolved

f-dangel reviewed

View reviewed changes

test/core/derivatives/derivatives_test.py Show resolved Hide resolved


          move shape check inside method

b5210b9

schaefertim added 5 commits

July 22, 2021 09:24


          docstring

27c67e0


          format

492e2b3


          rename methods

d23a472


          format

bcbb692


          format

d3b20c5

f-dangel reviewed

View reviewed changes

test/core/derivatives/implementation/autograd.py Outdated Show resolved Hide resolved


          use get_batch_axis

a245158

Owner

f-dangel commented Jul 27, 2021

Almost there. Can you resolve the remaining conflicts? I'll then go ahead and review once more, then merge.

schaefertim and others added 6 commits

July 27, 2021 10:55


          Merge branch 'development' into generalize-jac-t-interface

b626343

# Conflicts:
#	test/core/derivatives/derivatives_test.py
#	test/core/derivatives/implementation/autograd.py


          format

9bca808


          simplify: skip subsampling

db4cc1a


          [REF] Remove unnecessary device transfer

5fb28d9


          [REF] Inline call to get_batch_axis

515ca0e


          [DEL] Remove skip_no_param condition

8d3850e

f-dangel reviewed

View reviewed changes

test/core/derivatives/derivatives_test.py Outdated Show resolved Hide resolved

schaefertim and others added 5 commits

July 27, 2021 13:50


          [REF] tidy up test_param_mjp

f47d963


          [REF] tidy up test_param_mjp

6bf5485


          [DEL] Remove explicit delete statements

f17ad58


          [TEST] Add LSTM with small input to test hessian_is_zero

f6a738f


          [REF] More explicit imports

6637d70

f-dangel changed the title ~~[Refactor] Generalize jac_t interface~~ [REF] Introduce shared matrix parameter-Jacobian products

f-dangel merged commit 75c73c2 into f-dangel:development

schaefertim deleted the generalize-jac-t-interface branch

August 4, 2021 09:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet