Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waiting - MessageSender interface ,ConsolePrintMessageSender 구현 #31

Closed
chanwooo opened this issue Nov 5, 2022 · 0 comments · Fixed by #36
Closed

Waiting - MessageSender interface ,ConsolePrintMessageSender 구현 #31

chanwooo opened this issue Nov 5, 2022 · 0 comments · Fixed by #36
Assignees
@chanwooo

Comments

@chanwooo
Copy link
Contributor

chanwooo commented Nov 5, 2022

Waiting - MessageSender interface ,ConsolePrintMessageSender 구현

작업내용

[ ] interface 생성
[ ] ConsolePrintMessageSender 구현
[ ] 테스트작성
@chanwooo chanwooo self-assigned this Nov 5, 2022
chanwooo added a commit that referenced this issue Nov 10, 2022
@chanwooo
#31-MessageSender 분리
451aa34 
- MessageSender interface 작성
- ConsoleLogMessageSender 작성
- ConsoleLogMessageSenderTest 작성
- 기존 코드 변경
@chanwooo chanwooo linked a pull request Nov 10, 2022 that will close this issue
Feature #31 - message sender 분리 #36
Merged
chanwooo added a commit that referenced this issue Nov 14, 2022
@chanwooo
#31-ConsoleLogMessageSender 리뷰 반영
9f83467 
- @component -> @service
- test에서 before each대신 직접 객체생성
chanwooo added a commit that referenced this issue Nov 14, 2022
@chanwooo
Feature #31 - message sender 분리 (#36)
c19b663 
* #31-MessageSender 분리
- MessageSender interface 작성
- ConsoleLogMessageSender 작성
- ConsoleLogMessageSenderTest 작성
- 기존 코드 변경

* #31-ConsoleLogMessageSender 리뷰 반영
- @component -> @service
- test에서 before each대신 직접 객체생성
chanwooo added a commit that referenced this issue Nov 22, 2022
@chanwooo
Merge 31 (#50)
0fa50b2 
* #21-변수명 변경 phone -> phoneNumber

* #21-타입변경 Integer -> int

* #21-안쓰는 파일 삭제

* #21-사용하지않는 필드 제거

* #21-QuingService 일부 구현
append
getList
countForward
doneWaiting

* #21-QuingService test 일부 구현

* #21-주석 삭제

* #21-append 중복 방지 로직 추가

* #21-waiting cancel 구현

* #21-exception 패키지 이동

* #21-test코드 작성

* #21-cancel 리턴 타입 변경

* #22-message 전송 관련 부분 print로 임시 구현

* #22-message 전송 관련 부분 test 작성

* #22-test에 불필요한 공백 제거

* #22- test코드 logger 적용

* #22- test코드 given, when, then 분리

* #22- test코드 logger 적용

* #31-MessageSender 분리
- MessageSender interface 작성
- ConsoleLogMessageSender 작성
- ConsoleLogMessageSenderTest 작성
- 기존 코드 변경

* #31-ConsoleLogMessageSender 리뷰 반영
- @component -> @service
- test에서 before each대신 직접 객체생성

* getbyuserid 추가
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chanwooo chanwooo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature #31 - message sender 분리 f-lab-edu/quing
1 participant
@chanwooo