Skip to content

Commit

Permalink
#31-ConsoleLogMessageSender 리뷰 반영
Browse files Browse the repository at this point in the history
- @component -> @service
- test에서 before each대신 직접 객체생성
  • Loading branch information
chanwooo committed Nov 14, 2022
1 parent 451aa34 commit 9f83467
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

import lombok.extern.slf4j.Slf4j;
import org.springframework.stereotype.Component;
import org.springframework.stereotype.Service;

@Slf4j
@Component
@Service
public class ConsoleLogMessageSender implements MessageSender {

@Override
Expand All @@ -13,4 +15,4 @@ public boolean send(String phoneNumber, String message) {
log.info("message = " + message);
return true;
}
}
}
12 changes: 2 additions & 10 deletions src/test/java/flab/quing/waiting/ConsoleLogMessageSenderTest.java
Original file line number Diff line number Diff line change
@@ -1,28 +1,20 @@
package flab.quing.waiting;

import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.springframework.boot.test.system.CapturedOutput;
import org.springframework.boot.test.system.OutputCaptureExtension;

import static org.junit.jupiter.api.Assertions.*;

@ExtendWith(OutputCaptureExtension.class)
class ConsoleLogMessageSenderTest {

MessageSender messageSender;

@BeforeEach
void beforeEach() {
messageSender = new ConsoleLogMessageSender();
}
private final MessageSender messageSender = new ConsoleLogMessageSender();

@Test
void send(CapturedOutput output) {
messageSender.send("010-0000-0000", "hi test");

Assertions.assertThat(output).contains("test");
}
}
}

0 comments on commit 9f83467

Please sign in to comment.