-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTS-9.x (stage 2) #4
Conversation
@dzhus Work in progress. For now just partially refactored |
dmcc-ws/Main.hs
Outdated
data Config = | ||
Config | ||
data Config | ||
= Config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzhus If you have multiple constructors they will be at the same column:
data Foo
= Bar
| Baz
| Bzz
Or for records:
data RFoo
= RBar
{ foo :: Int
, bar :: Int
}
| RBaz
{ bzz :: Int
, zzz :: Int
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это я там ёбу дал, надо писать
data Foo = Foo
{ kek :: Double
, foo :: String
}
Суммы-рекордов вообще нахуй запретить надо, вместо них использовать generic-lens (типобезопаснее).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzhus Я что-то не понял про какие "суммы-рекордов" ты говоришь?
which are already declared in package.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я ещё пару дней почешу репу, но вроде по коду сейчас норм. Было бы неплохо протестировать на тестовом серваке :)
@dzhus Да как норм, там же ещё эти вызовы |
Было бы вообще неплохо как-нибудь замокать api авайи, чтобы автотесты написать. |
@dzhus |
Там |
added type signatures for top-level bindings and stuff
- using DMCC.Prelude everywhere where it's needed - added Control.Monad.Logger to DMCC.Prelude (it was there but haven't been exported) - fixed some warnings
На данный момент подчищены все ворнинги. Осталось только избавиться от вермишели с |
@dzhus Вроде готово, по-моему можно сливать в мастер. |
Тип логгера инициализируется в самой верхней монаде единожды. |
No description provided.