Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Crystal 0.12.0 (YAML.parse) #7

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Upgrade to Crystal 0.12.0 (YAML.parse) #7

merged 1 commit into from
Mar 9, 2016

Conversation

cjgajard
Copy link
Contributor

@cjgajard cjgajard commented Mar 3, 2016

Breaking change on Crystal 0.12.0 (2016-02-16):

YAML.load was renamed to YAML.parse, and it now returns a YAML::Any.

$ crystal build src/guardian.cr --release
Error in ./src/guardian.cr:167: instantiating 'Guardian::Watcher:Class#new()'

Guardian::Watcher.new
                  ^~~

instantiating 'Guardian::Watcher#initialize()'

in ./src/guardian.cr:32: undefined method 'load_all' for YAML:Module

        YAML.load_all(File.read(file)).each do |yaml|
             ^~~~~~~~

f added a commit that referenced this pull request Mar 9, 2016
Upgrade to Crystal 0.12.0 (YAML.parse)
@f f merged commit be7077d into f:master Mar 9, 2016
@f
Copy link
Owner

f commented Mar 9, 2016

Thanks!

@cjgajard cjgajard deleted the upgrade-0.12 branch March 10, 2016 02:37
@cjgajard
Copy link
Contributor Author

Thanks for merging 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants