Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in README #40

Closed
JonasMunck opened this issue Jun 25, 2018 · 2 comments · Fixed by #41
Closed

Typo in README #40

JonasMunck opened this issue Jun 25, 2018 · 2 comments · Fixed by #41

Comments

@JonasMunck
Copy link
Contributor

The comment //It's optional, 'loading'by default. is (as far as I can see) wrong, default vuex module is wait.

new Vue({
  el: '#app',
  store,
  wait: new VueWait({
    useVuex: true, // You must pass this option `true` to use Vuex
    vuexModuleName: 'vuex-example-module' // It's optional, `loading` by default.
  }),
});
@f
Copy link
Owner

f commented Jun 25, 2018

You can fix it and open a PR or I'll? Which one do you prefer? :)

@JonasMunck
Copy link
Contributor Author

I can do it :)

JonasMunck pushed a commit to JonasMunck/vue-wait that referenced this issue Jun 25, 2018
@f f closed this as completed in #41 Jun 25, 2018
f pushed a commit that referenced this issue Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants