Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newly opened players become unmuted upon syncing #15

Open
jonahhb opened this issue Feb 11, 2024 · 3 comments
Open

Newly opened players become unmuted upon syncing #15

jonahhb opened this issue Feb 11, 2024 · 3 comments
Assignees
@jonahhb
Labels
bug Something isn't working
Milestone
Done

Comments

@jonahhb
Copy link
Collaborator

jonahhb commented Feb 11, 2024

Newly opened players become unmuted upon syncing.

This is an MVF1 issue I think? also happens when you sync using s on the keyboard.
@jonahhb jonahhb added bug Something isn't working MVF1 Issue Issue with MVF1 outside of plugin's control labels Feb 11, 2024
@jonahhb
Copy link
Collaborator Author

jonahhb commented Feb 11, 2024

waitToSync() is the is the 'duct tape' fix for the MVF1 issue. It is currently (at least yesterday when I was looking at it) infinitely waiting over and over again. It probably has something to do with the updates that were made to the MVF1 API since it was implemented.

@jonahhb jonahhb self-assigned this Feb 11, 2024
@jonahhb jonahhb added this to the In Progress milestone Feb 11, 2024
@jonahhb jonahhb removed the MVF1 Issue Issue with MVF1 outside of plugin's control label Feb 11, 2024
@jonahhb jonahhb modified the milestones: In Progress, Fixed Locally Feb 11, 2024
jonahhb referenced this issue Feb 11, 2024
@jonahhb
solves #14, #12 (kinda lol)
60a3e77
@jonahhb jonahhb modified the milestones: Fixed Locally, Done Feb 13, 2024
jonahhb added a commit that referenced this issue Feb 13, 2024
@jonahhb
solves #15, #12 (kinda lol)
6630d58
@ManCaveMedia
Copy link
Contributor

I believe this was solved in the plugin, since it works as expected now.
You might want to mark this issue as solved and close it. 😉

@jonahhb
Copy link
Collaborator Author

jonahhb commented Feb 21, 2024

Noted, will close after the next release to the Elgato marketplace is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahhb jonahhb

Labels
bug Something isn't working
Projects
None yet
Milestone
Done
Development

No branches or pull requests
2 participants
@ManCaveMedia @jonahhb