Generate BundleInfo.plist for macos #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
force-pushed
the
bundleinfo_macos_plugin
branch
2 times, most recently
from
a44359d
to
4870c91
Compare
mwestphal
force-pushed
the
bundleinfo_macos_plugin
branch
from
4870c91
to
28c314a
Compare
Meakk
reviewed
Mar 31, 2024
Meakk
reviewed
Mar 31, 2024
Meakk
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rather simple but a bit naive implementation for generating BundleInfo.plist during generation.
We could instead reparse the JSON but since this is quite simple, I've done it like that.
Also plugin developers maybe be happy to have access to this string if ever needed.