Cache baked HDRI #502
Merged
Cache baked HDRI #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 94.06% 94.44% +0.38%
==========================================
Files 97 111 +14
Lines 4834 5168 +334
==========================================
+ Hits 4547 4881 +334
Misses 287 287
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mwestphal
requested changes
Dec 16, 2022
library/VTKExtensions/Rendering/vtkF3DCachedSpecularTexture.cxx
Outdated
Show resolved
Hide resolved
|
Could explain what it doest in the descr ? there is some complexitry and I dont grasp it all yet. |
Meakk
force-pushed
the
hdri-cache
branch
7 times, most recently
from
f1a7cbf
to
4fc8327
Compare
Meakk
force-pushed
the
hdri-cache
branch
3 times, most recently
from
911400f
to
d56d03d
Compare
mwestphal
reviewed
Jan 5, 2023
mwestphal
reviewed
Jan 5, 2023
mwestphal
reviewed
Jan 5, 2023
mwestphal
reviewed
Jan 5, 2023
mwestphal
reviewed
Jan 5, 2023
mwestphal
reviewed
Jan 5, 2023
mwestphal
reviewed
Jan 5, 2023
mwestphal
reviewed
Jan 5, 2023
Meakk
force-pushed
the
hdri-cache
branch
4 times, most recently
from
ccdebf1
to
b27b26c
Compare
Meakk
force-pushed
the
hdri-cache
branch
2 times, most recently
from
b35d766
to
6fb8ddc
Compare
mwestphal
reviewed
Jan 19, 2023
library/VTKExtensions/Rendering/Testing/TestF3DCachedTextures.cxx
Outdated
Show resolved
Hide resolved
When using a HDRI, the PBR engine is generating 3 data: - a LUT 2D images (static texture) - 9 RGB spherical harmonics values (related to the HDRI) - a mipmap cubemap (related to the HDRI) These data are quite expensive to bake depending on the user GPU, so this PR copy the result to cache files in order to reuse them if the user uses the same HDRI again which is likely to happen.
mwestphal
approved these changes
Jan 20, 2023
mwestphal
pushed a commit
that referenced
this pull request
Feb 10, 2024
When using a HDRI, the PBR engine is generating 3 data: - a LUT 2D images (static texture) - 9 RGB spherical harmonics values (related to the HDRI) - a mipmap cubemap (related to the HDRI) These data are quite expensive to bake depending on the user GPU, so this PR copy the result to cache files in order to reuse them if the user uses the same HDRI again which is likely to happen.
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
When using a HDRI, the PBR engine is generating 3 data: - a LUT 2D images (static texture) - 9 RGB spherical harmonics values (related to the HDRI) - a mipmap cubemap (related to the HDRI) These data are quite expensive to bake depending on the user GPU, so this PR copy the result to cache files in order to reuse them if the user uses the same HDRI again which is likely to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a HDRI, the PBR engine is generating 3 data:
These data are quite expensive to bake depending on the user GPU, so this PR copy the result to cache files in order to reuse them if the user uses the same HDRI again which is likely to happen.