fix BW newline handling #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of presence of the symbol "\n" in response from BW jq crashes if you use echo to print response
|
Hi Vlad, Thank you for waiting and for the change. I've tested your changes and they works. Thank you again for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of presence of the symbol "\n" in response from BW jq crashes if you use
echoto print response:jq: parse error: Invalid string: control characters from U+0000 through U+001F must be escaped at line 2, column 1.Using
printf "%s"is better than using echo in scripts where consistency and predictability regarding newline and other special characters are necessary. Quoting variable is good practice in sh.