Fix MPI world creation of size 1 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
added
bug
Shillaker
requested changes
Jun 16, 2021
| @@ -43,6 +43,19 @@ TEST_CASE_METHOD(MpiBaseTestFixture, "Test world creation", "[mpi]") | |||
| world.destroy(); | |||
| } | |||
|
|
|||
| TEST_CASE_METHOD(MpiBaseTestFixture, "Test creating world of size 1", "[mpi]") | |||
There was a problem hiding this comment.
I think this test could be a bit more specific in checking the effect we're trying to avoid (i.e. initialising the world but not sending messages). It would look a lot like the test above where we check a valid world initialisation.
// Create a world of size 1
MpiWorld world;
world.create(msg, worldId, 1);
// Check details are set up properly
REQUIRE(world.getSize() == 1);
REQUIRE(world.getId() == worldId);
REQUIRE(world.getUser() == user);
REQUIRE(world.getFunction() == func);
// Check no messages are sent
REQUIRE(sch.getRecordedMessagesAll().empty());
Shillaker
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running MPI applications with world size 1 would not work as we'd call
callFunctionswith an empty protobuf message, and the library would raise an error.Adding a simple check, and a test that (surprisingly) failed before and now passes.