Re-factor MPI native tests to run as distributed tests #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
force-pushed
the
mpi-dist-tests
branch
2 times, most recently
from
71d78f6
to
45b90ef
Compare
csegarragonz
force-pushed
the
mpi-dist-tests
branch
from
45b90ef
to
9f03987
Compare
csegarragonz
force-pushed
the
mpi-dist-tests
branch
from
8456a64
to
a90cc13
Compare
csegarragonz
commented
Nov 29, 2021
| @@ -43,6 +43,33 @@ std::set<std::string> getExecGraphHosts(const ExecGraph& graph) | |||
| return getExecGraphHostsForNode(graph.rootNode); | |||
| } | |||
|
|
|||
| std::vector<std::string> getMpiRankHostsFromExecGraphNode( | |||
There was a problem hiding this comment.
I reckon this method may be too MPI-specific for ExecGraph.cpp but I am not sure where to put it.
csegarragonz
force-pushed
the
mpi-dist-tests
branch
from
a90cc13
to
d6a459a
Compare
csegarragonz
commented
Nov 29, 2021
| - name: "Build examples" | ||
| run: inv examples | ||
| - name: "Run example to check" | ||
| run: inv examples.execute check | ||
|
|
||
| mpi_native: |
There was a problem hiding this comment.
The mpi_native tests will now run as part of the distributed tests. What also means that will be checked against each new commit in a PR (not just when bumping docker images).
csegarragonz
commented
Nov 29, 2021
| @@ -1,15 +1,9 @@ | |||
| #include <faabric/mpi/mpi.h> | |||
There was a problem hiding this comment.
For all MPI examples I've just had to remove the main function, and change the method name and namespace.
Note that I've opted to add a nested namespace, tests::mpi, as some function names where quite general.
csegarragonz
force-pushed
the
mpi-dist-tests
branch
from
48f3b86
to
347f338
Compare
csegarragonz
force-pushed
the
mpi-dist-tests
branch
2 times, most recently
from
ef2344c
to
2df20de
Compare
csegarragonz
force-pushed
the
mpi-dist-tests
branch
from
2df20de
to
e3265cd
Compare
|
May re-open this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I adapt all the existing
mpi-nativetests to run in our current distributed test setting. Most of the code in place can be re-used with very minimal changes.Two tests are left with the
[.]tag as they usedMPI_Win_createwhich we removed some time ago.