Faabric update: MPI queue-less local messages, reworked async #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
approved these changes
Jun 15, 2021
|
Would be good to merge this to see if it fixes the MPI test issues I keep seeing. |
|
Indeed, as tests have passed first try for me. |
Shillaker
changed the title
|
Note that this may be required to compile against latest Faabric master: #435 . |
csegarragonz
force-pushed
the
bump-faabric
branch
2 times, most recently
from
822e06c
to
e058dfe
Compare
csegarragonz
force-pushed
the
bump-faabric
branch
from
e058dfe
to
05e5d76
Compare
|
@Shillaker re-requested a review, as things have changed a bit since you last approved. |
Shillaker
approved these changes
Jun 17, 2021
csegarragonz
force-pushed
the
bump-faabric
branch
from
c36eb70
to
1a89dd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the faabric dependency to include (among others) the major changes introduced to the MPI port in faasm/faabric#105 and faasm/faabric#111.
I have also had to merge in the per-host flushing and dirty page integration from #435 together with a fix for a possible race condition in faasm/faabric#115.