Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we were using C code (or C language linkage) for anything under the
src/sgx
directory. This is not really needed.According to the SGX reference, enclave code can be written in both
C
andC++
. However, special rules apply forECalls
andOCalls
. Citing the developer reference:Enclave interface functions are limited to C (no C++).
(p.26, table)OCALL functions must be C functions, or C++ functions with C linkage.
(p.31)The diff is very large, but mostly due to indentation issues.