Clean FDs #735
Merged
Clean FDs #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Mar 30, 2023
| @@ -125,6 +122,9 @@ void WAMRWasmModule::doBindToFunction(faabric::Message& msg, bool cache) | |||
|
|
|||
| void WAMRWasmModule::bindInternal(faabric::Message& msg) | |||
| { | |||
| // Prepare the filesystem | |||
There was a problem hiding this comment.
For WAMR we need to make sure that this gets callled on every reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we prepare a filesystem (once per
WasmModulelifecycle), we pre-open the required file descriptors, and keep adding new ones as WASM code opens files.When
reset-ing the module, we need to bring the filesystem back to the original state, as otherwise execution will fail. This includes clearing the existing filedescriptor map.I add a regression test that catches this for WAMR (this was not an issue for WAVM, I think because during reset we move back to the original cached module).
I was thinking of adding the regression test in the
test_file_descriptor.cppfile, but then I decided against it. However, in the process I added a test fixture for that file.