Pass input-data encoded as base64
#753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving from ad-hoc JSON (de-) serialisation to using Protobuf's JSON utilities, we broke the encoding/decoding of the
input-datafield. This field is marked asbytesin the schema (I think it could be just astingbut that may be a matter for a different PR), therefore Protobuf expects the field to be base64 encoded. See this StackOverflow post for reference.In this PR I fix this issue in faasm, and bump the CPP and Python submodules to include similar fixes. The calling logic is replicated, thus the fix needs to be replicated. Hopefully when we actually move
faasmclito a different repo we will end with this replication.See faasm/cpp#114 and faasm/python#28