Extract tests app versions to versions.properties #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will replace the versions.properties with environment variables instead. I had issues initially using environment variable but it was because compileSDKVersion was read as a String instead of an Integer |
vincentbrison
suggested changes
Apr 9, 2020
|
Could you change the target branch from |
I think we should make it the default branch. 👍 |
vincentbrison
previously approved these changes
Apr 9, 2020
sjcqs
dismissed
vincentbrison’s stale review
Maybe we should pass the android SDK version too, by default we are supporting Android version up to builds tool "29.0.3" in our Dockerfile
vincentbrison
approved these changes
Apr 9, 2020
vincentbrison
force-pushed
the
feature/test_project
branch
from
0976281
to
fb5b426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.