Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with prompt on iOS #163

Closed
gschrader opened this issue Jul 20, 2013 · 10 comments
Closed

Problem with prompt on iOS #163

gschrader opened this issue Jul 20, 2013 · 10 comments

Comments

@gschrader
Copy link

I built the latest code (0.3 had an unrelated issue so I can't use that) and am having issues with prompts (iPhone breaks, iPad seems to be ok, Safari/Chrome desktop seems fine).

If I enter a value and either hit go on the iOS keyboard or hit the OK (alertify) dialog button, the keyboard remains visible (even though the dialog and text field are gone) and the body ends up being disabled. I try touching some of my elements my callback ends up being called again.

Hopefully I've described this ok let me know if I'm not making any sense.

@gschrader
Copy link
Author

Played a bit more with this. If I hit done to hide the keyboard in the input field and then hit the alertify ok button, I get the same locked up behaviour, I don't get the weird extra callbacks though 😕

@fabien-d
Copy link
Owner

Is this only happening with the master branch (release 0.4.*)?

The 0.4 is only a release candidate so bugs are to be expected. I will listed as an 0.4 bug and look at it for the next RC.

What was the unrelated issue with 0.3?

@gschrader
Copy link
Author

Yes from master (I also tried the 0.4.0rc1 tag).

The issue in 0.3 was if you use enter to submit from the dialog (or in iOS the go button) it would still treat it as cancelled, so you could only use the OK alertify button. This occurs on the demo page right now. This seems to be ok in 0.4.

@lexoyo
Copy link

lexoyo commented Oct 7, 2013

hello
any news about this issue?
thank you :)

@fabien-d
Copy link
Owner

fabien-d commented Oct 7, 2013

I'll be looking at why this is happening in 0.3.*. I'm getting close to releasing the next version of alertify - 0.5.0 and this issue has been resolved.

I'll look into backporting to 0.3.*

@fabien-d
Copy link
Owner

fabien-d commented Oct 8, 2013

Fixed with ^. Will be part of 0.3.11

@lexoyo
Copy link

lexoyo commented Oct 8, 2013

great!!
will we be notified of the new version? on github?

On Tue, Oct 8, 2013 at 2:27 AM, Fabien Doiron notifications@github.comwrote:

Fixed with ^. Will be part of 0.3.11


Reply to this email directly or view it on GitHubhttps://github.com//issues/163#issuecomment-25856646
.

Alex Hoyau
+33 (0) 6 76 68 38 06
http://lexoyo.me
Recevoir les news de Silex Labs par mail
http://eepurl.com/F48q5

@fabien-d
Copy link
Owner

fabien-d commented Oct 8, 2013

Available now:

I will be updating the demo page and docs shortly.

@fabien-d
Copy link
Owner

fabien-d commented Oct 8, 2013

Closing

@fabien-d fabien-d closed this as completed Oct 8, 2013
@lexoyo
Copy link

lexoyo commented Oct 8, 2013

Great, it works, thank you!
I have included alertify.js in Silex
https://github.com/silexlabs/Silex

djrobinsa pushed a commit to djrobinsa/AlarmServer that referenced this issue Nov 8, 2013
I have an outstanding issue since it seems to have issues with iphone
fabien-d/alertify.js#163
djrobinsa pushed a commit to djrobinsa/AlarmServer that referenced this issue Nov 8, 2013
…he page

see fabien-d/alertify.js#163

I also hard code the input to tel until the following is addressed
fabien-d/alertify.js#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants