First fix for #203 #205
Merged
First fix for #203 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 97.17% 97.20% +0.03%
==========================================
Files 15 15
Lines 814 823 +9
Branches 325 334 +9
==========================================
+ Hits 791 800 +9
Misses 23 23 ☔ View full report in Codecov by Sentry. |
|
yes let's merge and release this fix and then we can hopefully find a good solution for the local imports during validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @schiller-manuel,
As it seems more people are reporting #203, maybe we can merge the first fix (the first working version from #204, not adding the extra files into the validation) to not block anybody. WDYT?
I think there is a bit of work on #204 still to handle some other cases.