-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Literal handling #217
Template Literal handling #217
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
- Coverage 97.26% 95.98% -1.28%
==========================================
Files 16 18 +2
Lines 840 922 +82
Branches 340 368 +28
==========================================
+ Hits 817 885 +68
- Misses 23 37 +14 ☔ View full report in Codecov by Sentry. |
Does it make sense to add tests to cover the unhit branches? |
it("should generate all combinations of 1 empty array", () => { | ||
const arrays = [[]]; | ||
const result = generateCombinations(arrays); | ||
expect(result).toEqual([""]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the result not an empty array []
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason, it would probably be more logical to be empty indeed.
Updated accordingly.
I don't think it does, other warnings in the lib are not covered either (and I believe those are the only non-covered branches) |
LGTM |
Why
This PR implement supports for #64 and #214
Issue #64
Transforms
into
Issue #214
Transforms
into