-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a timeoutErrorDelay similar to FCCurrentLocationGeocoder #4
Comments
Hi @kristian, |
@fabiocaccamo Sounds great. Thanks a ton! |
Hi @kristian, It means that if there are 5 services, each one would have a 3 seconds timeout (15/5=3) before switching to the next one, or alternatively, to avoid this case, each service would have a 15 seconds timeout, but the global timeout would be very very long (15*5=75) and it would be not clear. Have you any idea about how to implement it in a nice and clear way?! |
Hmm, I think it's most important how you decide to name the property. Both ways are fine, if it is clear, what will happen when setting the parameter. I would avoid setting a "global" timeout, which you divide internally, for a simple reason: Hope this helps. Regards, |
I think a good solution could be to have the possibility to set both: a |
I don't really understand why you need two properties? What's the difference in both? Also "timeout" and "delay" are kind of the same, so I wouldn't go for |
@fabiocaccamo Any update on this? This would be highly anticipated. Thanks a lot! 👍 |
@kristian I'm sorry, but I don't think I will have the time to do it this month... |
@fabiocaccamo Would you accept a pull request then, if I would provide you with one? :) |
@kristian sure, if it is ok! :) |
Sure, let me check back this afternoon. If I find time I'll provide you with a pull request. |
@fabiocaccamo done see #5 |
PS: I didn't change the podspec in the pull request. Please go ahead and adapt the podspec if possible. Thanks. |
@fabiocaccamo Would be great if you find some time to merge the change this weekend! 👍 Thanks a lot in advance. |
@fabiocaccamo Any news on merging #5? :-) Higly appreciate it, sorry for insisting so hard, but it would be great, if I havn't have to add this single dependency manually. Thanks!! |
@fabiocaccamo @kristian Hi! Do you have any news about merge this issue? |
Hello Fabio, thanks a lot for the library.
A minor request for improvement. At the moment you use the standard
NSURLConnection
connection timeout of 60 seconds. It would be favorable having a timeoutErrorDelay parameter just like in FCCurrentLocationGeocoder, because for the 4 GeoIP services you are using the total timeout sums up to 4 minutes. This is likely way to long for most applications.Thanks & regards, Kristian
The text was updated successfully, but these errors were encountered: