Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong reported HealthCheck-URI using custom -proxy.addr & -ui.addr #657

Closed
ttais2017 opened this issue May 16, 2019 · 1 comment · Fixed by #658
Closed

Wrong reported HealthCheck-URI using custom -proxy.addr & -ui.addr #657

ttais2017 opened this issue May 16, 2019 · 1 comment · Fixed by #658
Milestone

Comments

@ttais2017
Copy link

When starting fabio with custom port numbers, i.e.: fabio1.5.exe -proxy.addr :8888 -ui.addr :8887, the health check URI reported to Consul is wrong.

Current output:
< Registered fabio with health check to "http://[my-private-ip]:9998/health >

BugFix: the proxy.add parameter should be considered in the URL passed to Consul.

@pschultz
Copy link
Member

pschultz commented May 16, 2019

I agree that setting ui.addr should change the default address for service registration. Until that is fixed specify the -registry.consul.register.addr flag explicitly:

fabio1.5.exe -proxy.addr :8888 -ui.addr :8887 -registry.consul.register.addr :8887

Note that this has nothing to do with the proxy.addr flag; fabio registers its UI in consul, not the proxy port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants