config: let registry.consul.register.addr default to ui.addr #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always set registry.consul.register.addr to the value of ui.addr if the flag hasn't been specified. Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
pschultz
force-pushed
the
issue-657-default-registration-address
branch
from
a7ea05c
to
ba590ea
Compare
|
LGTM! |
aaronhurt
approved these changes
May 16, 2019
Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
pschultz
force-pushed
the
issue-657-default-registration-address
branch
from
1914a49
to
a0aaf3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always set registry.consul.register.addr to the value of ui.addr if the
flag hasn't been specified.
Fixes #657.