Check upstream X-Forwarded-Proto prior to redirect #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS load balancer terminates SSL and passes plain HTTP to fabio but does not offer the ability to do a schema redirect. Therefore, fabio running behind an AWS ELB with a schema redirect rule results in a redirect loop. This PR fixes fabiolb#448.
We now generate the redirectURL in the lookup function and use it for loop detection. We also cache the redirectURL in the target for later use to prevent re-generation.
|
Thanks a lot! |
aaronhurt
commented
Mar 19, 2018
| @@ -99,8 +99,7 @@ func (p *HTTPProxy) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| if t.RedirectCode != 0 { | |||
| redirectURL := t.GetRedirectURL(requestURL) | |||
There was a problem hiding this comment.
@magiconair I know this already got merged but I was thinking maybe the above if statement should be t.RedirectCode != 0 && t.RedirectURL != nil just to be safe?
magiconair
added a commit
that referenced
this pull request
Mar 26, 2018
Check if the redirect url is not nil. See #466
magiconair
added a commit
that referenced
this pull request
Mar 26, 2018
Issue #466: make redirect code more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS load balancer terminates SSL and passes plain HTTP
to fabio but does not offer the ability to do a schema redirect.
Therefore, fabio running behind an AWS ELB with a schema
redirect rule results in a redirect loop.
Fixes #448