Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check upstream X-Forwarded-Proto prior to redirect #466

Merged
merged 4 commits into from
Mar 19, 2018
Merged

Check upstream X-Forwarded-Proto prior to redirect #466

merged 4 commits into from
Mar 19, 2018

Commits on Mar 13, 2018

  1. Check upstream X-Forwarded-Proto prior to redirect 

    The AWS load balancer terminates SSL and passes plain HTTP
to fabio but does not offer the ability to do a schema redirect.

Therefore, fabio running behind an AWS ELB with a schema
redirect rule results in a redirect loop.  This PR fixes fabiolb#448.
    Aaron Hurt committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    9250e1c View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. make redirect protection more generic

    @aaronhurt
    aaronhurt committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    5b8f04a View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Further improvements to redirect loop detection. 

    We now generate the redirectURL in the lookup function
and use it for loop detection.  We also cache the redirectURL
in the target for later use to prevent re-generation.
    @aaronhurt
    aaronhurt committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    71d2972 View commit details
    Browse the repository at this point in the history

  2. Ensure BuildRedirectURL enforces non-empty path

    @aaronhurt
    aaronhurt committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    9b23390 View commit details
    Browse the repository at this point in the history