Refactor consul service monitor #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussion is on #559 |
Refactor the set of functions which watch the consul state and generate the route commands into a set of objects to make them testable and extendable.
... and finally add some tests.
The code which updates the routing table from consul was using a single go routine to fetch data from consul. This can be a slow process if consul has lots of registered services. This patch adds an option `registry.consul.serviceMonitors` to increase the concurrency for the route updates.
magiconair
force-pushed
the
issue-558
branch
from
a0f965a
to
b498073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the consul service monitor and provides a new option
registry.consul.serviceMonitorsto configure the concurrency for routing table updates.Fabio uses one go routine by default to fetch status information from Consul when the service status changes. This can be too slow when lots of services are registered. The new
registry.consul.serviceMonitorsoption configures how many go routines fabio will use to fetch service data from Consul.This patch unfortunately supersedes #559 from @galen0624 since this was a good opportunity to finally refactor the service monitor code to make it more extensible and testable.
Fixes #558