Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor consul service monitor #564

Merged
merged 4 commits into from
Nov 15, 2018
Merged

Refactor consul service monitor #564

merged 4 commits into from
Nov 15, 2018

Commits on Nov 15, 2018

  1. consul: refactor service monitor 

    Refactor the set of functions which watch the consul state
and generate the route commands into a set of objects to make
them testable and extendable.
    @magiconair
    magiconair committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    9096f2a View commit details
    Browse the repository at this point in the history

  2. consul: move build route command logic to separate object 

    ... and finally add some tests.
    @magiconair
    magiconair committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    b6621c6 View commit details
    Browse the repository at this point in the history

  3. consul: fetch route updates concurrently 

    The code which updates the routing table from consul was using a
single go routine to fetch data from consul. This can be a slow
process if consul has lots of registered services.

This patch adds an option `registry.consul.serviceMonitors`
to increase the concurrency for the route updates.
    @magiconair
    magiconair committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    630a67e View commit details
    Browse the repository at this point in the history

  4. doc: document registry.consul.serviceMonitors

    @magiconair
    magiconair committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    b498073 View commit details
    Browse the repository at this point in the history