Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Fix XSS vulnerability #588

Merged
merged 1 commit into from
Feb 25, 2019
Merged

ui: Fix XSS vulnerability #588

merged 1 commit into from
Feb 25, 2019

Conversation

pschultz
Copy link
Member

Service names, sources, destinations, and route options were passed
directly to jQuery.html(), enabling trivial XSS.

Instead, pass them to jQuery.text() and jQuery.attr().

$ consul kv put fabio/config - <<EOF
route add service-a<script>alert('name')</script> /<script>alert('src')</script> http://127.0.0.1:8080/<script>alert('dst')</script> opts "foo=<script>alert('opts')</script>"
EOF

This will conflict with #587, but the conflict is easy to resolve either way.

Service names, sources, destinations, and route options were passed
directly to jQuery.html(), enabling trivial XSS.

Instead, pass them to jQuery.text() and jQuery.attr().
@magiconair magiconair added this to the 1.5.11 milestone Feb 25, 2019
@magiconair magiconair merged commit 18e5fca into master Feb 25, 2019
@magiconair magiconair deleted the fix-xss branch February 25, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants