Deprecate deregisterCriticalServiceAfter option #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deregisterCriticalServiceAfter option applied to the HTTP health check for services that are registered in Consul. Commit ea3a365 introduced additional Consul TTL checks. These TTL checks have DeregisterCriticalServiceAfter set to the minimum of one minute and will therefore always beat or tie the HTTP check's DeregisterCriticalServiceAfter option, rendering it obsolete. Document this fact in the usage message and HTML docs. Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
aaronhurt
requested changes
Jul 16, 2019
|
Re-running tests via Travis integration. |
aaronhurt
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deregisterCriticalServiceAfter option applied to the HTTP health
check for services that are registered in Consul.
#664 introduced additional Consul TTL checks. These TTL
checks have DeregisterCriticalServiceAfter set to the minimum of one
minute and will therefore always beat or tie the HTTP check's
DeregisterCriticalServiceAfter option, rendering it obsolete.
Document this fact in the usage message and HTML docs.