-
Notifications
You must be signed in to change notification settings - Fork 292
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
5333b3d
commit 58b2a3f
Showing
2 changed files
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58b2a3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm curious, the
Seq.ts
, was it written by hand or generated?58b2a3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to you for reporting! Do you need a release very quickly or can you do it with the workaround for now?
About the files in fable-core, I originally wrote them in JS mainly by translating the modules in FunScript.Core manually. Then another contributor translated them to TypeScript and we've been tweaking the files since then. Though some have been actually compiled with Fable (Map, Set and BigInteger) with some manual tweaks (mostly to export functions independently to help tree shaking by JS bundlers). I've also the idea of adding Fable compilation to fable-core build so we can add modules in F# directly in the future, but I haven't implemented it yet (shouldn't be difficult with fable-splitter now).
58b2a3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, a new release is not an emergency, thanks :)
58b2a3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation.