Add some list methods #1406
Merged
Add some list methods #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank for contributing to Fable 2 ❤️ At first look, code looks fine to me :) (I didn't tested it, I just read the code) |
|
Awesome, thanks a lot for this @zaaack! I had to make a couple of adjustments but it's working fine 👏 👏 👏 Now we have 1245 tests passing for Fable 2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
mapFold,mapFoldBack,findBack,tryFindBack,tryFindIndexBack,findIndexBack,contains,except,groupBy,countByinList.fs, andtruncate,containsinArray.fs(by accident).@alfonsogarciacaro Plz review, thx~