Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle fsx file with dotnet core 3 #1892

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

rfrerebe
Copy link
Contributor

@rfrerebe rfrerebe commented Sep 2, 2019

#1886
Added a new test project for Fable.Cli

fable-compiler#1886
Added a new test project for Fable.Cli
@rfrerebe rfrerebe changed the title Handle fsx file with dotnet core 3 [WIP] Handle fsx file with dotnet core 3 Sep 3, 2019
@rfrerebe rfrerebe changed the title [WIP] Handle fsx file with dotnet core 3 Handle fsx file with dotnet core 3 Sep 3, 2019
@rfrerebe
Copy link
Contributor Author

rfrerebe commented Sep 3, 2019

Hello @alfonsogarciacaro ,

You can merge this PR if you wish. New tests are being run by factory.
Ideally, it would be cool to also add to test fsx build, but that would need adding paket in your build process.
Other option is to wait for fsx files to handle references directly (see this PR dotnet/fsharp#5850)

Let me know, if you are interested

@alfonsogarciacaro
Copy link
Member

Thanks @rfrerebe!

It's good to have some kind of integration tests, I've been too lazy for that :) If you want to test the compilation of an .fsx script using Paket, you should only need to include Paket in the directory of the test project without touching the overall repo structure, right? If that's the case, I'm OK with you adding Paket in a folder within the tests directory 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants