Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] System.Array.Resize: also handle the case where the array is null #3716

Merged
merged 4 commits into from Jan 29, 2024
Merged

[JS] System.Array.Resize: also handle the case where the array is null #3716

merged 4 commits into from Jan 29, 2024

Conversation

chkn
Copy link
Contributor

@chkn chkn commented Jan 26, 2024

In my initial PR, I missed that the docs say the array can be null, in which case a new array is allocated.

@chkn chkn requested a review from ncave January 26, 2024 23:06
@MangelMaxime MangelMaxime merged commit 7dc1791 into fable-compiler:main Jan 29, 2024
1 check passed
@chkn chkn deleted the fix-system-array-resize branch February 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncave ncave ncave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chkn @ncave @MangelMaxime