Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Fixes custom equality on records #3734

Merged
merged 3 commits into from Feb 5, 2024
Merged

[Python] Fixes custom equality on records #3734

merged 3 commits into from Feb 5, 2024

Conversation

dbrattli
Copy link
Collaborator

@dbrattli dbrattli commented Feb 5, 2024

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 5, 2024
View reviewed changes
src/Fable.Transforms/Python/PythonPrinter.fs Dismissed Show dismissed Hide dismissed
@MangelMaxime
Copy link
Member

@dbrattli I rebased the PR on main because we made some changes to the formatting rules.

@dbrattli dbrattli merged commit 600e985 into main Feb 5, 2024
19 checks passed
@dbrattli dbrattli deleted the issue3717 branch February 5, 2024 22:13
zprobinson pushed a commit to zprobinson/Fable that referenced this pull request Feb 6, 2024
@dbrattli @MangelMaxime
[Python] Fixes custom equality on records (fable-compiler#3734)
0951afb 
* Fixes custom equality on records

* Re-enable all checks

* Fix formatting issues since we changed max width in main

---------

Co-authored-by: Maxime Mangel <mangel.maxime@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] Nested type with Custom Equality gives false negative equality
2 participants
@dbrattli @MangelMaxime